Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update GCR quotas #1619

Merged
merged 1 commit into from
Mar 31, 2023
Merged

update GCR quotas #1619

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions pkg/gcrane/copy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,15 +41,15 @@ var Keychain = authn.NewMultiKeychain(google.Keychain, authn.DefaultKeychain)
//
// These numbers are based on GCR's posted quotas:
// https://cloud.google.com/container-registry/quotas
// - 30k requests per 10 minutes.
// - 500k requests per 24 hours.
// - 50k requests per 10 minutes.
// - 1M requests per 24 hours.
//
// On error, we will wait for:
// - 6 seconds (in case of very short term 429s from GCS), then
// - 1 minute (in case of temporary network issues), then
// - 10 minutes (to get around GCR 10 minute quotas), then fail.
//
// TODO: In theory, we could keep retrying until the next day to get around the 500k limit.
// TODO: In theory, we could keep retrying until the next day to get around the 1M limit.
func GCRBackoff() retry.Backoff {
return retry.Backoff{
Duration: 6 * time.Second,
Expand Down