Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remote.Descriptor.Schema1() #1626

Merged
merged 1 commit into from
Apr 6, 2023
Merged

Conversation

jonjohnsonjr
Copy link
Collaborator

@jonjohnsonjr jonjohnsonjr commented Apr 5, 2023

This will allow just passing a remote.Descriptor to remote.Pusher and
also gives an escape hatch for filesystem access to schema1 images.

@codecov-commenter
Copy link

codecov-commenter commented Apr 5, 2023

Codecov Report

Merging #1626 (88fab54) into main (6ac92e8) will decrease coverage by 0.03%.
The diff coverage is 80.52%.

❗ Current head 88fab54 differs from pull request most recent head dd39fd7. Consider uploading reports for the commit dd39fd7 to get more accurate results

@@            Coverage Diff             @@
##             main    #1626      +/-   ##
==========================================
- Coverage   72.61%   72.59%   -0.03%     
==========================================
  Files         118      119       +1     
  Lines        9462     9513      +51     
==========================================
+ Hits         6871     6906      +35     
- Misses       1889     1902      +13     
- Partials      702      705       +3     
Impacted Files Coverage Δ
pkg/v1/types/types.go 60.00% <0.00%> (-15.00%) ⬇️
pkg/v1/remote/schema1.go 71.42% <71.42%> (ø)
pkg/v1/remote/write.go 59.94% <73.17%> (-0.06%) ⬇️
pkg/v1/remote/descriptor.go 72.12% <87.71%> (-0.24%) ⬇️
pkg/v1/remote/catalog.go 58.06% <100.00%> (ø)
pkg/v1/remote/delete.go 57.14% <100.00%> (ø)
pkg/v1/remote/image.go 75.59% <100.00%> (ø)
pkg/v1/remote/index.go 70.37% <100.00%> (ø)
pkg/v1/remote/layer.go 63.41% <100.00%> (ø)
pkg/v1/remote/list.go 74.68% <100.00%> (+0.32%) ⬆️
... and 4 more

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

This will allow just passing a remote.Descriptor to remote.Pusher and
also gives an escape hatch for filesystem access to schema1 images.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants