-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(remote): pass retryBackoff and retryPredicate options to transport #1628
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jonjohnsonjr aside from the 429 change, do you see a reason we shouldn't retry with the custom semantics when we're also injecting a custom transport?
I had these be intentionally separate because if you want to control the transport retry behavior, you should be using |
@jonjohnsonjr if so, I don't get what are all these options for.. |
This Pull Request is stale because it has been open for 90 days with |
This is still desired. @jonjohnsonjr is this still something you don't want for go-containerregistry? |
@jonjohnsonjr Could you expand on
please? There are three settings that control retry behavior - status codes, predicate, and backoff - and currently all three are set in different ways:
This inconsistency is quite unexpected and confusing, and this PR would immediately resolve that confusion. I am also very curious about @aslafy-z 's question - if |
@imjasonh @jonjohnsonjr Can you please reconsider this PR? Thank you |
This Pull Request is stale because it has been open for 90 days with |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1628 +/- ##
==========================================
+ Coverage 71.67% 71.88% +0.21%
==========================================
Files 123 122 -1
Lines 9935 9832 -103
==========================================
- Hits 7121 7068 -53
+ Misses 2115 2081 -34
+ Partials 699 683 -16 ☔ View full report in Codecov by Sentry. |
This PR is still desired. |
This Pull Request is stale because it has been open for 90 days with |
f6da36f
to
d40aa02
Compare
Signed-off-by: Zadkiel AHARONIAN <hello@zadkiel.fr>
d40aa02
to
10c7e61
Compare
I just rebased and fixed conflicts to this PR. Now that #1635 is merged, can we merge that one? Thank you |
is this going to be merged soon? |
I would love to see this merged.. |
options.retryBackoff
andoptions.retryPredicate
to new transport.Fixes #1692