Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't export whiteouts for single layers #1629

Merged
merged 1 commit into from
Apr 6, 2023

Conversation

jonjohnsonjr
Copy link
Collaborator

Fixes #1623

Before:

$ crane export quay.io/integreatly/3scale-bundle:v0.8.0 | tar -tv | grep wh
-rwxr-xr-x  0 0      0           0 Dec 31  1969 root/.wh..wh..opq
-rwxr-xr-x  0 0      0           0 Dec 31  1969 metadata/.wh..wh..opq
-rwxr-xr-x  0 0      0           0 Dec 31  1969 manifests/.wh..wh..opq

After:

$ crane export quay.io/integreatly/3scale-bundle:v0.8.0 | tar -tv | grep wh
$

@codecov-commenter
Copy link

codecov-commenter commented Apr 6, 2023

Codecov Report

Merging #1629 (db05c1a) into main (d958444) will decrease coverage by 0.06%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main    #1629      +/-   ##
==========================================
- Coverage   72.58%   72.52%   -0.06%     
==========================================
  Files         119      119              
  Lines        9520     9530      +10     
==========================================
+ Hits         6910     6912       +2     
- Misses       1904     1911       +7     
- Partials      706      707       +1     
Impacted Files Coverage Δ
pkg/v1/types/types.go 50.00% <0.00%> (-10.00%) ⬇️
pkg/crane/export.go 62.50% <72.72%> (-5.93%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@imjasonh imjasonh merged commit 93be9c4 into google:main Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ggcr: crane.Export not handling whiteout files in single-layer images
3 participants