Implement remote.Pusher #1633
Merged
Implement remote.Pusher #1633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonjohnsonjr
force-pushed
the
remote-pusher
branch
from
c4a9d30
to
4ce245c
Compare
Codecov Report
@@ Coverage Diff @@
## main #1633 +/- ##
==========================================
- Coverage 72.30% 72.06% -0.24%
==========================================
Files 119 120 +1
Lines 9566 9760 +194
==========================================
+ Hits 6917 7034 +117
- Misses 1943 2008 +65
- Partials 706 718 +12
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
jonjohnsonjr
force-pushed
the
remote-pusher
branch
2 times, most recently
from
a07dca2
to
3927b90
Compare
The Pusher handles multiplexing across multiple repositories and deduplicating in-flight uploads. This removes the need to do an awkward dance around re-using auth handshakes by passing custom transports. This also fixes limitations in remote.MultiWrite around streaming layers and multiple repositories.
jonjohnsonjr
force-pushed
the
remote-pusher
branch
from
3927b90
to
dffb52f
Compare
This will be faster than doing the handshake twice.
imjasonh
approved these changes
Apr 7, 2023
| "github.com/google/go-containerregistry/pkg/v1/types" | ||
| "github.com/google/go-containerregistry/pkg/v1/validate" | ||
| ) | ||
|
|
||
| func streamable(t *testing.T) v1.Layer { | ||
| t.Helper() | ||
| rl, err := random.Layer(1024, types.OCIUncompressedLayer) |
There was a problem hiding this comment.
Isn't this a long way to say NopCloser(LimitReader(Rand, n))?
There was a problem hiding this comment.
I wanted it to be a valid filesystem for some reason.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Pusher handles multiplexing across multiple repositories and deduplicating in-flight uploads. This removes the need to do an awkward dance around re-using auth handshakes by passing custom transports.
This also fixes limitations in remote.MultiWrite around streaming layers and multiple repositories.