Add remote.Puller #1644
Merged
Add remote.Puller #1644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1644 +/- ##
==========================================
- Coverage 72.07% 72.03% -0.04%
==========================================
Files 120 121 +1
Lines 9772 9860 +88
==========================================
+ Hits 7043 7103 +60
- Misses 2010 2033 +23
- Partials 719 724 +5
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
jonjohnsonjr
force-pushed
the
pagination
branch
2 times, most recently
from
f9faf99
to
a1568b4
Compare
imjasonh
approved these changes
Apr 18, 2023
| @@ -25,8 +25,9 @@ import ( | |||
| "github.com/google/go-containerregistry/pkg/v1/remote/transport" | |||
| ) | |||
|
|
|||
| type catalog struct { | |||
| type Catalogs struct { | |||
There was a problem hiding this comment.
remote.Catalog is already defined 😅
pkg/v1/remote/descriptor.go
Outdated
Comment on lines
113
to
111
| func (f *fetcher) head(ctx context.Context, ref name.Reference) (*v1.Descriptor, error) { | ||
| return f.headManifest(ctx, ref, allManifestMediaTypes) | ||
| } |
There was a problem hiding this comment.
This method doesn't add much, can we just have callers pass allManifestMediaTypes themselves?
This PR adds a Puller implementation and uses it in `crane ls` and `crane catalog` to stream results for each page.
jonjohnsonjr
force-pushed
the
pagination
branch
from
a1568b4
to
8d104df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a Puller implementation and uses it in
crane lsandcrane catalogto stream results for each page.