Change return type of remote.Referrers #1652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Actually using this was cumbersome because it just returns a struct. This is a breaking change, but I don't think it's a huge deal because not too many people should be using this yet (and we're < 1.0.0).
|
cc @jdolitsky |
|
What methods did you find yourself needing from the interface that you didn't get from the struct? |
E.g. if I want to save referrers to an OCI layout, I can just do that with a |
|
Makes sense, thanks for that example. |
imjasonh
approved these changes
Apr 17, 2023
Codecov Report
@@ Coverage Diff @@
## main #1652 +/- ##
==========================================
- Coverage 72.19% 72.11% -0.09%
==========================================
Files 120 120
Lines 9771 9782 +11
==========================================
Hits 7054 7054
- Misses 2002 2009 +7
- Partials 715 719 +4
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
jdolitsky
approved these changes
Apr 17, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually using this was cumbersome because it just returns a struct. This is a breaking change, but I don't think it's a huge deal because not too many people should be using this yet (and we're < 1.0.0).