Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(mutate): simplify work with layers in MutateTime, add test #1716

Closed
wants to merge 1 commit into from

Conversation

sumkincpp
Copy link

@sumkincpp sumkincpp commented May 31, 2023

This PR refactors current code for working with Time Mutation

PSS. the role of preparing of non-empty layers in newLayer, err := layerTime(layer, t) is not very clear to me, though it seems that we are taking only time from known next found layer. if they are initially collected without empty layers, then it seems the correct way to do

@github-actions
Copy link

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Keep fresh with the 'lifecycle/frozen' label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant