Use RWLock, limit scope of locking, write digest first #1734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattmoor
commented
Jun 16, 2023
| continue | ||
| } | ||
| if desc.MediaType.IsIndex() || desc.MediaType.IsImage() { | ||
| if _, found := m.manifests[repo][desc.Digest.String()]; !found { |
There was a problem hiding this comment.
This should be safe, even if m.manifests[repo] is uninitialized: https://go.dev/play/p/i3MTYkyWacp
Signed-off-by: Matt Moore <mattmoor@chainguard.dev>
mattmoor
force-pushed
the
manifests-rwlock
branch
from
1ec3795
to
30d1947
Compare
Codecov Report
@@ Coverage Diff @@
## main #1734 +/- ##
==========================================
+ Coverage 71.87% 71.96% +0.08%
==========================================
Files 122 122
Lines 9822 9832 +10
==========================================
+ Hits 7060 7076 +16
+ Misses 2082 2078 -4
+ Partials 680 678 -2
|
jonjohnsonjr
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.