-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add v1.Manifest 'artifactType' field from OCI spec #1931
base: main
Are you sure you want to change the base?
Conversation
Hi @jonjohnsonjr or @imjasonh any chance you could take a look at this? Thanks! |
@bmoylan, Thanks for doing the work on this. Any chance to get this into main any time soon? It would be super helpful as we start to see more OCI 1.1 adoption across the ecosystem. |
👋 Hey @jonjohnsonjr @imjasonh sorry for the pings but it would be great to get this reviewed when possible, thanks! |
Yeah, it'd be great to get this in. |
@bmoylan I've added a couple of extra bits for better
|
Set artifactType in fallback descriptor if present
I noticed this issue as well and it would be great to get this PR merged! Another issue with regards to diffs between the current implementation and the OCI 1.1 referrers specification is that the specification states that the referrer descriptors I opened PR #1998 to fix the "annotations" issue. I believe that merging these 2 PRs should make I didn't see an existing issue for this, so I filed #1997 to explicitly describe the issues. |
OCI has released v1.1.0 of the Image Spec which includes the artifactType field in the manifest json schema: https://github.com/opencontainers/image-spec/blob/v1.1.0/manifest.md#image-manifest-property-descriptions
Relevant to #1832 closed as stale