Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add v1.Manifest 'artifactType' field from OCI spec #1931

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

bmoylan
Copy link

@bmoylan bmoylan commented Apr 23, 2024

OCI has released v1.1.0 of the Image Spec which includes the artifactType field in the manifest json schema: https://github.com/opencontainers/image-spec/blob/v1.1.0/manifest.md#image-manifest-property-descriptions

Relevant to #1832 closed as stale

@bmoylan bmoylan changed the title v1.Manifest: Add 'artifactType' field from OCI spec feat: Add v1.Manifest 'artifactType' field from OCI spec Apr 23, 2024
@bmoylan
Copy link
Author

bmoylan commented Apr 29, 2024

Hi @jonjohnsonjr or @imjasonh any chance you could take a look at this? Thanks!

@cdupuis
Copy link

cdupuis commented Jun 14, 2024

@bmoylan, Thanks for doing the work on this. Any chance to get this into main any time soon? It would be super helpful as we start to see more OCI 1.1 adoption across the ecosystem.

@bmoylan
Copy link
Author

bmoylan commented Jun 15, 2024

👋 Hey @jonjohnsonjr @imjasonh sorry for the pings but it would be great to get this reviewed when possible, thanks!

@kipz
Copy link

kipz commented Jul 9, 2024

Yeah, it'd be great to get this in.

@kipz
Copy link

kipz commented Jul 23, 2024

@bmoylan I've added a couple of extra bits for better artifactType here: bmoylan#2

  • Set artifactType in fallback descriptor (if present)
  • Similarly for in-memory registry: set artifactType instead of config mediaType (if present)
  • Send artifactType filter to registry if supplied in call to referrers API

Set artifactType in fallback descriptor if present
@nmiyake
Copy link

nmiyake commented Aug 13, 2024

I noticed this issue as well and it would be great to get this PR merged!

Another issue with regards to diffs between the current implementation and the OCI 1.1 referrers specification is that the specification states that the referrer descriptors MUST have the annotations from the Image or ImageIndex, but currently this library doesn't do that.

I opened PR #1998 to fix the "annotations" issue. I believe that merging these 2 PRs should make go-containerregistry compliant in its behavior.

I didn't see an existing issue for this, so I filed #1997 to explicitly describe the issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants