Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go mod: upgrade to latest go #2008

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

go mod: upgrade to latest go #2008

wants to merge 14 commits into from

Conversation

imjasonh
Copy link
Collaborator

No description provided.

@imjasonh imjasonh changed the title style: upgrade to latest go go mod: upgrade to latest go Sep 11, 2024
@imjasonh imjasonh enabled auto-merge (squash) September 11, 2024 18:44
@imjasonh
Update style.yaml
65bee90
@imjasonh
Update bump-deps.yaml
1bf1743
@imjasonh
Update ghcr-auth.yaml
8ea202e
@imjasonh
Update e2e.yaml
6322b11
@imjasonh
some more
30d9871 
Signed-off-by: Jason Hall <jason@chainguard.dev>
@imjasonh
boilerplate
0ccaaed 
Signed-off-by: Jason Hall <jason@chainguard.dev>
@imjasonh
all the mods
a58361f 
Signed-off-by: Jason Hall <jason@chainguard.dev>
@imjasonh
Update e2e.yaml
1cb5f47
jonjohnsonjr
jonjohnsonjr reviewed Sep 11, 2024
View reviewed changes
pkg/authn/kubernetes/go.mod Outdated Show resolved Hide resolved
pkg/authn/k8schain/go.mod Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
@imjasonh
Copy link
Collaborator Author

Do we still need this?

@pjonsson
Copy link

The released 0.20.2 binary gets flagged for CVE-2024-34156 by Trivy:

┌─────────┬────────────────┬──────────┬────────┬───────────────────┬────────────────┬───────────────────────────────────────────────────────────┐
│ Library │ Vulnerability  │ Severity │ Status │ Installed Version │ Fixed Version  │                           Title                           │
├─────────┼────────────────┼──────────┼────────┼───────────────────┼────────────────┼───────────────────────────────────────────────────────────┤
│ stdlib  │ CVE-2024-34156 │ HIGH     │ fixed  │ 1.21.12           │ 1.22.7, 1.23.1 │ encoding/gob: golang: Calling Decoder.Decode on a message │
│         │                │          │        │                   │                │ which contains deeply nested structures...                │
│         │                │          │        │                   │                │ https://avd.aquasec.com/nvd/cve-2024-34156                │
└─────────┴────────────────┴──────────┴────────┴───────────────────┴────────────────┴───────────────────────────────────────────────────────────┘

so a Go with a fixed version of stdlib would be appreciated.

pjonsson
pjonsson reviewed Nov 12, 2024
View reviewed changes
cmd/krane/go.mod
@@ -1,6 +1,6 @@
module github.com/google/go-containerregistry/cmd/krane

go 1.18
go 1.23.1
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the other go.mod files dropped the patch version, is this file meant to still have them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonjohnsonjr jonjohnsonjr jonjohnsonjr left review comments

@pjonsson pjonsson pjonsson left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@imjasonh @pjonsson @jonjohnsonjr