-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement v1 image tarball generation in new legacy package #536
Conversation
Codecov Report
@@ Coverage Diff @@
## master #536 +/- ##
==========================================
- Coverage 73.25% 72.63% -0.62%
==========================================
Files 94 95 +1
Lines 4015 4221 +206
==========================================
+ Hits 2941 3066 +125
- Misses 703 759 +56
- Partials 371 396 +25
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a pkg/legacy/doc.go
and pkg/legacy/tarball/doc.go
with package comments?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is huge, thanks :)
Fixes #526
Add functions that can generate docker image tarballs in the v1 format. This is what docker save generates by default in version 18.09.3 today.
This is the same as #535 but adds the code to a new
legacy
package instead of thev1
package.