Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement v1 image tarball generation in new legacy package #536

Merged
merged 17 commits into from
Sep 20, 2019

Conversation

smukherj1
Copy link
Contributor

Fixes #526
Add functions that can generate docker image tarballs in the v1 format. This is what docker save generates by default in version 18.09.3 today.

This is the same as #535 but adds the code to a new legacy package instead of the v1 package.

@codecov-io
Copy link

codecov-io commented Sep 18, 2019

Codecov Report

Merging #536 into master will decrease coverage by 0.61%.
The diff coverage is 62.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #536      +/-   ##
==========================================
- Coverage   73.25%   72.63%   -0.62%     
==========================================
  Files          94       95       +1     
  Lines        4015     4221     +206     
==========================================
+ Hits         2941     3066     +125     
- Misses        703      759      +56     
- Partials      371      396      +25
Impacted Files Coverage Δ
pkg/v1/partial/with.go 64.03% <ø> (ø) ⬆️
pkg/v1/partial/uncompressed.go 46.42% <0%> (-10.1%) ⬇️
pkg/v1/tarball/write.go 60.82% <100%> (ø) ⬆️
pkg/v1/tarball/image.go 72.88% <36.84%> (-4.37%) ⬇️
pkg/legacy/tarball/write.go 71.02% <71.02%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5340dba...81fbd7b. Read the comment docs.

pkg/legacy/config.go Show resolved Hide resolved
pkg/v1/config.go Outdated Show resolved Hide resolved
pkg/legacy/tarball/write.go Outdated Show resolved Hide resolved
pkg/v1/tarball/write.go Outdated Show resolved Hide resolved
pkg/v1/tarball/write.go Outdated Show resolved Hide resolved
pkg/legacy/tarball/write.go Show resolved Hide resolved
pkg/legacy/config.go Show resolved Hide resolved
pkg/v1/tarball/image.go Outdated Show resolved Hide resolved
pkg/v1/tarball/image.go Outdated Show resolved Hide resolved
pkg/v1/tarball/image.go Show resolved Hide resolved
Copy link
Collaborator

@jonjohnsonjr jonjohnsonjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a pkg/legacy/doc.go and pkg/legacy/tarball/doc.go with package comments?

pkg/legacy/tarball/write.go Show resolved Hide resolved
pkg/legacy/config.go Outdated Show resolved Hide resolved
pkg/legacy/tarball/write_test.go Show resolved Hide resolved
pkg/v1/tarball/image.go Outdated Show resolved Hide resolved
pkg/name/tag.go Outdated Show resolved Hide resolved
pkg/v1/partial/uncompressed.go Outdated Show resolved Hide resolved
pkg/v1/partial/uncompressed.go Outdated Show resolved Hide resolved
pkg/v1/partial/with.go Show resolved Hide resolved
pkg/legacy/tarball/write.go Show resolved Hide resolved
pkg/v1/partial/uncompressed.go Show resolved Hide resolved
pkg/v1/tarball/image.go Show resolved Hide resolved
pkg/v1/partial/uncompressed.go Show resolved Hide resolved
Copy link
Collaborator

@jonjohnsonjr jonjohnsonjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is huge, thanks :)

@jonjohnsonjr jonjohnsonjr merged commit 4478e83 into google:master Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add repositories files to image tarballs
3 participants