Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect mediaType of index in layout #570

Merged
merged 2 commits into from
Oct 14, 2019

Conversation

glyn
Copy link
Contributor

@glyn glyn commented Oct 14, 2019

... rather than assuming all indexes have media type application/vnd.oci.image.index.v1+json.

... rather than assuming all indexes have media type
application/vnd.oci.image.index.v1+json.
@codecov-io
Copy link

codecov-io commented Oct 14, 2019

Codecov Report

Merging #570 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #570      +/-   ##
==========================================
+ Coverage   72.93%   72.94%   +0.01%     
==========================================
  Files          97       97              
  Lines        4375     4377       +2     
==========================================
+ Hits         3191     3193       +2     
  Misses        777      777              
  Partials      407      407
Impacted Files Coverage Δ
pkg/v1/layout/index.go 84.61% <100%> (+0.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3d713f...ac6a293. Read the comment docs.

@glyn
Copy link
Contributor Author

glyn commented Oct 14, 2019

Add a hand-crafted test which should be reworked once the testdata is made reproducible.

The testdata should be replaced once the testdata directory contents are made
reproducible.
@imjasonh imjasonh merged commit 0e086ae into google:master Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants