Compare mount targets by string #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The defaulting logic is being deferred to accessors, which means comparing the structs of a repo or registry will result in non-equal references even if they're semantically equivalent. This converts them to strings to fix that.
mattmoor
approved these changes
Mar 10, 2020
jonjohnsonjr
added a commit
to jonjohnsonjr/ko
that referenced
this pull request
Mar 10, 2020
jonjohnsonjr
added a commit
to jonjohnsonjr/ko
that referenced
this pull request
Mar 10, 2020
jonjohnsonjr
added a commit
to ko-build/ko
that referenced
this pull request
Mar 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #689
The defaulting logic is being deferred to accessors, which means
comparing the structs of a repo or registry will result in non-equal
references even if they're semantically equivalent. This converts them
to strings to fix that.