Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

daemon: Ensure we call NegotiateAPIVersion first #736

Merged
merged 1 commit into from
Jul 7, 2020

Conversation

jonjohnsonjr
Copy link
Collaborator

Fixes #734

@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2020

Codecov Report

Merging #736 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #736   +/-   ##
=======================================
  Coverage   79.39%   79.39%           
=======================================
  Files         102      102           
  Lines        4683     4683           
=======================================
  Hits         3718     3718           
  Misses        534      534           
  Partials      431      431           
Impacted Files Coverage Δ
pkg/v1/daemon/image.go 67.39% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92c877e...09c707c. Read the comment docs.

@jonjohnsonjr jonjohnsonjr merged commit 72edbad into google:master Jul 7, 2020
@jonjohnsonjr jonjohnsonjr deleted the negotiation branch July 7, 2020 16:54
afbjorklund pushed a commit to afbjorklund/go-containerregistry that referenced this pull request Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker API version negotiation happens too late
3 participants