Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remote.WithContext #744

Merged
merged 1 commit into from
Jul 17, 2020
Merged

Conversation

jonjohnsonjr
Copy link
Collaborator

Fixes #743

This allows passing a context.Context into any remote operations.

This allows passing a context.Context into any remote operations.
@jpreese
Copy link

jpreese commented Jul 17, 2020

Wow that was fast, I'm super excited! Upgrading to this as soon as it's released 🤣

@jonjohnsonjr
Copy link
Collaborator Author

The trick is to file an issue that's not very hard to fix when I'm procrastinating doing other stuff 😉

@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2020

Codecov Report

Merging #744 into master will decrease coverage by 0.29%.
The diff coverage is 68.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #744      +/-   ##
==========================================
- Coverage   79.39%   79.09%   -0.30%     
==========================================
  Files         102      102              
  Lines        4683     4712      +29     
==========================================
+ Hits         3718     3727       +9     
- Misses        534      546      +12     
- Partials      431      439       +8     
Impacted Files Coverage Δ
pkg/v1/remote/list.go 74.19% <0.00%> (-2.48%) ⬇️
pkg/v1/remote/options.go 80.00% <20.00%> (-8.58%) ⬇️
pkg/v1/remote/catalog.go 64.38% <33.33%> (-3.27%) ⬇️
pkg/v1/remote/image.go 82.95% <50.00%> (-1.76%) ⬇️
pkg/v1/remote/descriptor.go 82.01% <71.42%> (-2.77%) ⬇️
pkg/v1/remote/write.go 67.34% <84.00%> (-0.15%) ⬇️
pkg/v1/remote/check.go 71.42% <100.00%> (+1.42%) ⬆️
pkg/v1/remote/delete.go 61.90% <100.00%> (ø)
pkg/v1/remote/index.go 89.32% <100.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72597da...e65caa4. Read the comment docs.

@jonjohnsonjr jonjohnsonjr merged commit a849933 into google:master Jul 17, 2020
@jonjohnsonjr jonjohnsonjr deleted the remote-with-context branch July 17, 2020 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Context with remote.Image and remote.Get
4 participants