Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for rebase omitting os/arch config properties #752

Merged
merged 1 commit into from
Aug 5, 2020
Merged

Fix for rebase omitting os/arch config properties #752

merged 1 commit into from
Aug 5, 2020

Commits on Aug 4, 2020

  1. Fix for rebase omitting os/arch config properties (google#751) 

    * Quick fix for missing `os` and `architecture` config properties, required by config spec [1]

* Also include unspec'd `os.version` property which is required for Windows images to run on Windows containers [2]

This implementation takes these three properties from newBase, which most accurately defines the newly rebased image's os/architecture. If the properties were taken from original, it would prevent reuse of de-facto ABI-compatible top layers with differing old and new base images (i.e. data-only top layers rebased from amd64 to arm, Windows os.version upgrades).

This does not address additional, optional config properties that are currently being omitted during rebase such as `author` and `created`.

Fixes [google#751]

[1]: https://github.com/opencontainers/image-spec/blob/master/config.md#properties
[2]: https://docs.microsoft.com/en-us/virtualization/windowscontainers/deploy-containers/version-compatibility#matching-container-host-version-with-container-image-versions

Signed-off-by: Micah Young <ymicah@vmware.com>
    Micah Young committed Aug 4, 2020
    Configuration menu
    Copy the full SHA
    c8eb274 View commit details
    Browse the repository at this point in the history