Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split tarball progress test from write_test.go #756

Merged
merged 1 commit into from
Aug 21, 2020

Conversation

jonjohnsonjr
Copy link
Collaborator

This example test reaches out to the internet, which isn't ideal.

For now, I'm just going to split it off into a separate file so it's
easier to exclude.

Also, fix some whitespace nits.

This example test reaches out to the internet, which isn't ideal.

For now, I'm just going to split it off into a separate file so it's
easier to exclude.

Also, fix some whitespace nits.
@codecov-commenter
Copy link

Codecov Report

Merging #756 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #756   +/-   ##
=======================================
  Coverage   79.02%   79.02%           
=======================================
  Files         102      102           
  Lines        4734     4734           
=======================================
  Hits         3741     3741           
  Misses        550      550           
  Partials      443      443           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d4814a...87fcd52. Read the comment docs.

@jonjohnsonjr jonjohnsonjr merged commit cecf390 into google:master Aug 21, 2020
@jonjohnsonjr jonjohnsonjr deleted the split-test branch August 21, 2020 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants