Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect tag size limit #760

Merged
merged 1 commit into from
Sep 1, 2020
Merged

Fix incorrect tag size limit #760

merged 1 commit into from
Sep 1, 2020

Conversation

alexey-igrychev
Copy link
Contributor

@alexey-igrychev alexey-igrychev commented Sep 1, 2020

A tag name must be valid ASCII and may contain lowercase and uppercase letters, digits, underscores, periods and dashes. A tag name may not start with a period or a dash and may contain a maximum of 128 characters.

A tag name must be valid ASCII and may contain lowercase and uppercase letters, digits, underscores, periods and dashes. A tag name may not start with a period or a dash and may contain a maximum of 128 characters.
@google-cla
Copy link

google-cla bot commented Sep 1, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@alexey-igrychev
Copy link
Contributor Author

@googlebot I signed it!

@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2020

Codecov Report

Merging #760 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #760   +/-   ##
=======================================
  Coverage   79.02%   79.02%           
=======================================
  Files         102      102           
  Lines        4734     4734           
=======================================
  Hits         3741     3741           
  Misses        550      550           
  Partials      443      443           
Impacted Files Coverage Δ
pkg/name/tag.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e3ad46...a73cc6c. Read the comment docs.

alexey-igrychev added a commit to werf/werf that referenced this pull request Sep 1, 2020
github.com/alexey-igrychev/go-containerregistry == master + google/go-containerregistry#760
alexey-igrychev added a commit to werf/werf that referenced this pull request Sep 1, 2020
github.com/alexey-igrychev/go-containerregistry == master + google/go-containerregistry#760
alexey-igrychev added a commit to werf/werf that referenced this pull request Sep 1, 2020
github.com/alexey-igrychev/go-containerregistry == master + google/go-containerregistry#760
Copy link
Collaborator

@jonjohnsonjr jonjohnsonjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jonjohnsonjr jonjohnsonjr merged commit ded15ea into google:master Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants