Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GGCR to K8s 1.18 libs #767

Merged
merged 1 commit into from
Sep 10, 2020
Merged

Update GGCR to K8s 1.18 libs #767

merged 1 commit into from
Sep 10, 2020

Conversation

mattmoor
Copy link
Collaborator

No description provided.

@mattmoor
Copy link
Collaborator Author

Beyond simply bumping the dependencies, the meat of this change is accommodating the breaking change in K8s 1.18 to expect ctx in all client-go calls.

@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2020

Codecov Report

Merging #767 into master will not change coverage.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #767   +/-   ##
=======================================
  Coverage   79.03%   79.03%           
=======================================
  Files         102      102           
  Lines        4736     4736           
=======================================
  Hits         3743     3743           
  Misses        550      550           
  Partials      443      443           
Impacted Files Coverage Δ
pkg/authn/k8schain/k8schain.go 68.25% <50.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a19315...99ef165. Read the comment docs.

@imjasonh imjasonh merged commit d42b6a2 into google:master Sep 10, 2020
@mattmoor mattmoor deleted the k8s-1-18 branch September 10, 2020 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants