[remote] Don't close streaming layers ourselves #768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"The request Body, if non-nil, will be closed by the underlying Transport, even on errors." https://golang.org/pkg/net/http/#Client.Do Fixes google#707
imjasonh
approved these changes
Sep 11, 2020
Codecov Report
@@ Coverage Diff @@
## master #768 +/- ##
==========================================
- Coverage 79.03% 79.02% -0.01%
==========================================
Files 102 102
Lines 4736 4735 -1
==========================================
- Hits 3743 3742 -1
Misses 550 550
Partials 443 443
Continue to review full report at Codecov.
|
imjasonh
approved these changes
Sep 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"The request Body, if non-nil, will be closed by the underlying
Transport, even on errors."
https://golang.org/pkg/net/http/#Client.Do
Fixes #707