Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement crane digest using a HEAD request #784

Merged
merged 1 commit into from
Oct 13, 2020

Conversation

imjasonh
Copy link
Collaborator

Before

$ crane digest ubuntu
sha256:bc2f7250f69267c9c6b66d7b6a81a54d3878bb85f1ebb5f951c896d13e6ba537

After

$ go  run  ./cmd/crane/ digest ubuntu
sha256:bc2f7250f69267c9c6b66d7b6a81a54d3878bb85f1ebb5f951c896d13e6ba537

This wouldn't count as a "pull" from Dockerhub, which might be helpful in some cases.

@codecov-io
Copy link

codecov-io commented Oct 11, 2020

Codecov Report

Merging #784 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #784      +/-   ##
==========================================
+ Coverage   75.91%   75.94%   +0.02%     
==========================================
  Files         102      102              
  Lines        4139     4144       +5     
==========================================
+ Hits         3142     3147       +5     
  Misses        546      546              
  Partials      451      451              
Impacted Files Coverage Δ
pkg/crane/digest.go 100.00% <100.00%> (ø)
pkg/crane/get.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9d94b7...9666f21. Read the comment docs.

@jonjohnsonjr jonjohnsonjr merged commit e39e523 into google:master Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants