Use pinned k8s.io/code-generator for codegen #785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates hack/update-codegen.sh to use the pinned code-generator version to avoid always pulling in the latest release with go get. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
Added deepcopy-gen directive to avoid generating DeepCopy methods for Update type, which fails generation due to embedded error interface not supporting DeepCopy methods. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
imjasonh
approved these changes
Oct 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates hack/update-codegen.sh to use the pinned code-generator version
to avoid always pulling in the latest release with go get.
Signed-off-by: hasheddan georgedanielmangum@gmail.com
Added deepcopy-gen directive to avoid generating DeepCopy methods for
Update type, which fails generation due to embedded error interface not
supporting DeepCopy methods
Signed-off-by: hasheddan georgedanielmangum@gmail.com
Fixes #782