Add --platform CLI option for crane #788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmd/crane/cmd/root.go
Outdated
| platform *v1.Platform | ||
| } | ||
|
|
||
| func (pv *platformValue) Set(platform string) error { |
There was a problem hiding this comment.
We'll probably also want to allow a third value for the variant. We do this in ko and I'd like to be consistent.
containerd also allows this, and in the fullness of time I'd like to be compatible with what they allow, but for now let's just do the os/arch/variant form.
I think that's fine, we use that same order in ko, so that works for me: https://github.com/google/ko#multi-platform-images |
|
Added support for variant. |
|
Ah the travis failures -- you'll need to run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
--platformoption for the crane CLI tool.I added a if-statement in
pkg/crane/options.gothat we don't get a nil pointer dereference if WithPlatform is called with nil. We could also catch this in cmd/crane/cmd/root.go` but I think it would in general make sense to avoid the nil pointer dereference.I changed the error output in
pkg/v1/remote/index.goto the formos/arch. This is not necessary but i think we should use the same form in the error output and the flag. I think this is quite arbitrary but I prefer os/arch over arch/os.