Add --platform CLI option for crane #788
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
--platform
option for the crane CLI tool.I added a if-statement in
pkg/crane/options.go
that we don't get a nil pointer dereference if WithPlatform is called with nil. We could also catch this in cmd/crane/cmd/root.go` but I think it would in general make sense to avoid the nil pointer dereference.I changed the error output in
pkg/v1/remote/index.go
to the formos/arch
. This is not necessary but i think we should use the same form in the error output and the flag. I think this is quite arbitrary but I prefer os/arch over arch/os.