Return basic auth from google.Keychain #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @hosungs |
imjasonh
approved these changes
Oct 22, 2020
Before, we were taking advantage of the fact that GCR will allow you to just send an access token as bearer auth, but apparently this breaks `gcrane cp` if it's your first push to a registry, so this change returns basic auth to force us to always do a token exchange.
jonjohnsonjr
force-pushed
the
google-auth-token-exchange
branch
from
2228041
to
c686a8b
Compare
Codecov Report
@@ Coverage Diff @@
## master #791 +/- ##
==========================================
- Coverage 75.55% 75.54% -0.02%
==========================================
Files 102 102
Lines 4169 4171 +2
==========================================
+ Hits 3150 3151 +1
- Misses 565 566 +1
Partials 454 454
Continue to review full report at Codecov.
|
briandealwis
added a commit
to briandealwis/skaffold
that referenced
this pull request
Nov 27, 2020
nkubala
pushed a commit
to GoogleContainerTools/skaffold
that referenced
this pull request
Nov 30, 2020
…5064) * Update pack v0.15.0 and drop replace of Azure/go-autorest * go mod vendor * Update code to pack v0.15 (debug still requires adjusting) * Add debug support for CNB Platform API 0.4 * missed tests * Fix fallout from google/go-containerregistry#791 * Make the TestDebug/buildpacks integration tests pass Tests were failing as I wasn't rewriting the entrypoint, so that Platform 0.4-style process executables (/cnb/process/web) continued through and the debug transformers wouldn't recognize the executable. - fix adjustCommandLine() and add tests - fix testutil.isNil to handle function pointers - narrow isCNBImage() to only allow entrypoint to be 1-element array and add tests - go style nits (rename isCnbImage -> isCNBImage, godoc style) * Mark TestDevPortForwardDeletePod to be skipped due to flakiness
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, we were taking advantage of the fact that GCR will allow you to
just send an access token as bearer auth, but apparently this breaks
gcrane cpif it's your first push to a registry, so this changereturns basic auth to force us to always do a token exchange.