-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return basic auth from google.Keychain #791
Return basic auth from google.Keychain #791
Conversation
FYI @hosungs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Before, we were taking advantage of the fact that GCR will allow you to just send an access token as bearer auth, but apparently this breaks `gcrane cp` if it's your first push to a registry, so this change returns basic auth to force us to always do a token exchange.
2228041
to
c686a8b
Compare
Codecov Report
@@ Coverage Diff @@
## master #791 +/- ##
==========================================
- Coverage 75.55% 75.54% -0.02%
==========================================
Files 102 102
Lines 4169 4171 +2
==========================================
+ Hits 3150 3151 +1
- Misses 565 566 +1
Partials 454 454
Continue to review full report at Codecov.
|
…5064) * Update pack v0.15.0 and drop replace of Azure/go-autorest * go mod vendor * Update code to pack v0.15 (debug still requires adjusting) * Add debug support for CNB Platform API 0.4 * missed tests * Fix fallout from google/go-containerregistry#791 * Make the TestDebug/buildpacks integration tests pass Tests were failing as I wasn't rewriting the entrypoint, so that Platform 0.4-style process executables (/cnb/process/web) continued through and the debug transformers wouldn't recognize the executable. - fix adjustCommandLine() and add tests - fix testutil.isNil to handle function pointers - narrow isCNBImage() to only allow entrypoint to be 1-element array and add tests - go style nits (rename isCnbImage -> isCNBImage, godoc style) * Mark TestDevPortForwardDeletePod to be skipped due to flakiness
Before, we were taking advantage of the fact that GCR will allow you to
just send an access token as bearer auth, but apparently this breaks
gcrane cp
if it's your first push to a registry, so this changereturns basic auth to force us to always do a token exchange.