Remove hidden unit test dependency on GCR creds #793
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By having pkg/crane/copy_test.go set up its fake registry at
gcr.io
, this seems to trigger behavior that ends up looking for default GCP credentials to authorize pushes/pulls. This works fine when tests run in GCB, and presumably on most of our local workstations, where GCP creds happen to be available, but fails on GitHub Actions, where creds are not available.Instead of calling our fake registry "gcr.io", this change renames it to "xcr.io".
This change includes the Unit Tests action being added by #792, to check that this change fixes the unit test failure.