-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add remote.WithJobs and use it in remote.MultiWrite #803
Conversation
Codecov Report
@@ Coverage Diff @@
## master #803 +/- ##
==========================================
- Coverage 75.60% 74.88% -0.72%
==========================================
Files 102 103 +1
Lines 4185 4312 +127
==========================================
+ Hits 3164 3229 +65
- Misses 566 606 +40
- Partials 455 477 +22
Continue to review full report at Codecov.
|
d085892
to
2265d79
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a TODO to Write
and WriteIndex
to respect WithJobs
?
2265d79
to
a4fb466
Compare
- default parallel is 4 - an error is returned if WithParallel is called with a value <= 0 We can probably reuse this to fetch and push blobs elsewhere in remote. MultiWrite'ing 123 distroless images with WithJobs(100) took 4s compared to 11s for the default.
a4fb466
to
7e43cbb
Compare
We can probably reuse this to fetch and push blobs elsewhere in remote.
MultiWrite'ing 123 distroless images with
WithParallel(100)
took 4s compared to 11s for the default.