Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when calculating tarball size of manifest #804

Merged
merged 1 commit into from
Nov 3, 2020

Conversation

tydra-wang
Copy link
Contributor

Manifest is marshalled repeatedly.

Manifest is marshalled repeatedly.
@codecov-io
Copy link

Codecov Report

Merging #804 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #804      +/-   ##
==========================================
+ Coverage   74.88%   74.91%   +0.02%     
==========================================
  Files         103      103              
  Lines        4312     4309       -3     
==========================================
- Hits         3229     3228       -1     
+ Misses        606      605       -1     
+ Partials      477      476       -1     
Impacted Files Coverage Δ
pkg/v1/tarball/write.go 62.42% <ø> (+0.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5040388...f0713db. Read the comment docs.

@jonjohnsonjr
Copy link
Collaborator

cc @deitch can you take a look?

Copy link
Collaborator

@deitch deitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense to me. I cannot understand how it worked before, unless I simply don't understand it now.

Copy link
Collaborator

@jonjohnsonjr jonjohnsonjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jonjohnsonjr jonjohnsonjr merged commit fb6ca2e into google:master Nov 3, 2020
@tydra-wang
Copy link
Contributor Author

It makes sense to me. I cannot understand how it worked before, unless I simply don't understand it now.

The size is only used to calculate the progress.
And the tarball padding makes error happens occasionally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants