Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix debug images #811

Merged
merged 1 commit into from
Nov 5, 2020
Merged

Fix debug images #811

merged 1 commit into from
Nov 5, 2020

Conversation

jonjohnsonjr
Copy link
Collaborator

Fixes #810

Copy link
Collaborator

@imjasonh imjasonh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could add a test in cloudbuild.yaml that debug has a shell too to prevent future typos🤔

@codecov-io
Copy link

codecov-io commented Nov 4, 2020

Codecov Report

Merging #811 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #811      +/-   ##
==========================================
+ Coverage   74.72%   74.77%   +0.04%     
==========================================
  Files         103      103              
  Lines        4313     4313              
==========================================
+ Hits         3223     3225       +2     
+ Misses        612      611       -1     
+ Partials      478      477       -1     
Impacted Files Coverage Δ
pkg/v1/cache/fs.go 70.00% <0.00%> (+3.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 051a6c0...e7967b0. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gcrane debug container does not have shell
3 participants