Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose v1/layout.WriteImage and WriteIndex #815

Merged
merged 1 commit into from
Nov 6, 2020

Conversation

deitch
Copy link
Collaborator

@deitch deitch commented Nov 5, 2020

Fixes #813

Signed-off-by: Avi Deitcher <avi@deitcher.net>
@jonjohnsonjr
Copy link
Collaborator

@mattmoor @imjasonh this CodeQL things sucks, I often do want to log credentials for debugging reasons.

@mattmoor
Copy link
Collaborator

mattmoor commented Nov 6, 2020

Logging credentials is a huge security problem, logs are often far more accessible than the credentials potentially logged to them. This has resulted in a large number of security incidents.

@codecov-io
Copy link

codecov-io commented Nov 6, 2020

Codecov Report

Merging #815 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #815   +/-   ##
=======================================
  Coverage   74.77%   74.77%           
=======================================
  Files         103      103           
  Lines        4313     4313           
=======================================
  Hits         3225     3225           
  Misses        611      611           
  Partials      477      477           
Impacted Files Coverage Δ
pkg/v1/layout/write.go 48.41% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a14ada4...e16abb5. Read the comment docs.

@jonjohnsonjr
Copy link
Collaborator

Thanks!

@jonjohnsonjr jonjohnsonjr merged commit 6a63025 into google:master Nov 6, 2020
@deitch deitch deleted the expose-layout-write branch November 6, 2020 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide ability to update an image layout, ensuring all of its content is available
4 participants