-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve transport.Error text #827
Conversation
Codecov Report
@@ Coverage Diff @@
## master #827 +/- ##
==========================================
+ Coverage 74.63% 74.64% +0.01%
==========================================
Files 103 103
Lines 4340 4342 +2
==========================================
+ Hits 3239 3241 +2
Misses 619 619
Partials 482 482
Continue to review full report at Codecov.
|
In ancitipation of: google/go-containerregistry#827
In anticipation of: google/go-containerregistry#827
Return "unexpected status code" instead of "unsupported". Instead of just printing the status code, include the http.StatusText. While debugging this, I encountered more MISSING stuff in the debug logs for URLs. Fix that. Add note to remote.Head about errors.
f5b024f
to
ffe4c1e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be nice to have 👍
In anticipation of: google/go-containerregistry#827
@jonjohnsonjr what's the empty |
🤫 |
My inability to successfully redirect stderr to stdout the first try, and my arrogance to just "git commit -a --amend" without looking. |
PRs welcome. |
Fixes #825
Return "unexpected status code" instead of "unsupported".
Instead of just printing the status code, include the http.StatusText.
While debugging this, I encountered more MISSING stuff in the debug logs
for URLs. Fix that.
Document that
remote.Head
errors can be retried withremote.Get
to get more details.