Improve transport.Error text #827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #827 +/- ##
==========================================
+ Coverage 74.63% 74.64% +0.01%
==========================================
Files 103 103
Lines 4340 4342 +2
==========================================
+ Hits 3239 3241 +2
Misses 619 619
Partials 482 482
Continue to review full report at Codecov.
|
imjasonh
approved these changes
Nov 12, 2020
jonjohnsonjr
added a commit
to jonjohnsonjr/rules_docker
that referenced
this pull request
Nov 12, 2020
In ancitipation of: google/go-containerregistry#827
jonjohnsonjr
added a commit
to jonjohnsonjr/rules_docker
that referenced
this pull request
Nov 12, 2020
In anticipation of: google/go-containerregistry#827
Return "unexpected status code" instead of "unsupported". Instead of just printing the status code, include the http.StatusText. While debugging this, I encountered more MISSING stuff in the debug logs for URLs. Fix that. Add note to remote.Head about errors.
jonjohnsonjr
force-pushed
the
error-text
branch
from
f5b024f
to
ffe4c1e
Compare
hasheddan
approved these changes
Nov 12, 2020
smukherj1
pushed a commit
to bazelbuild/rules_docker
that referenced
this pull request
Nov 13, 2020
In anticipation of: google/go-containerregistry#827
|
@jonjohnsonjr what's the empty |
🤫 |
|
My inability to successfully redirect stderr to stdout the first try, and my arrogance to just "git commit -a --amend" without looking. |
|
PRs welcome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #825
Return "unexpected status code" instead of "unsupported".
Instead of just printing the status code, include the http.StatusText.
While debugging this, I encountered more MISSING stuff in the debug logs
for URLs. Fix that.
Document that
remote.Headerrors can be retried withremote.Getto get more details.