Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix vet complaint #831

Merged
merged 1 commit into from
Nov 17, 2020
Merged

fix vet complaint #831

merged 1 commit into from
Nov 17, 2020

Conversation

deitch
Copy link
Collaborator

@deitch deitch commented Nov 17, 2020

go vet regularly complains about these two unkeyed fields. It doesn't really affect anything, but might as well have good hygiene.

Signed-off-by: Avi Deitcher <avi@deitcher.net>
@deitch
Copy link
Collaborator Author

deitch commented Nov 17, 2020

Also, it was bothering me 😀

@codecov-io
Copy link

codecov-io commented Nov 17, 2020

Codecov Report

Merging #831 (c3d8e02) into master (d4a7f2f) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #831   +/-   ##
=======================================
  Coverage   74.85%   74.85%           
=======================================
  Files         105      105           
  Lines        4379     4379           
=======================================
  Hits         3278     3278           
  Misses        619      619           
  Partials      482      482           
Impacted Files Coverage Δ
pkg/v1/random/image.go 80.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4a7f2f...c3d8e02. Read the comment docs.

Copy link
Collaborator

@jonjohnsonjr jonjohnsonjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing stuff just because it's bothering you is the bedrock of this project and arguably all of open source. Thanks :)

@jonjohnsonjr jonjohnsonjr merged commit 50fe4c4 into google:master Nov 17, 2020
@deitch deitch deleted the fix-time-vet branch November 17, 2020 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants