Parse WWW-Authenticate challenges on retry #846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use docker/distribution challenge library
Codecov Report
@@ Coverage Diff @@
## master #846 +/- ##
==========================================
- Coverage 74.72% 74.67% -0.05%
==========================================
Files 106 106
Lines 4427 4435 +8
==========================================
+ Hits 3308 3312 +4
- Misses 629 633 +4
Partials 490 490
Continue to review full report at Codecov.
|
imjasonh
approved these changes
Nov 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to recover from insufficient scope errors.
This PR introduces a dependency on
github.com/docker/distribution/registry/client/auth/challenge. We already had an indirect dependency on it through the daemon package, so maybe not a huge deal?