Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thunk-ify layout options #847

Merged
merged 1 commit into from
Mar 2, 2021
Merged

Conversation

jonjohnsonjr
Copy link
Collaborator

If we want to add anything other than descriptor mutators as options, we
need a place to do that, so this introduces an options struct that holds
options and thunk-ifies the existing descriptor mutators.

If we want to add anything other than descriptor mutators as options, we
need a place to do that, so this introduces an options struct that holds
options and thunk-ifies the existing descriptor mutators.
@codecov-io
Copy link

codecov-io commented Nov 29, 2020

Codecov Report

Merging #847 (24c04e1) into master (cf9d7b3) will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #847      +/-   ##
==========================================
+ Coverage   74.72%   74.84%   +0.11%     
==========================================
  Files         106      106              
  Lines        4427     4432       +5     
==========================================
+ Hits         3308     3317       +9     
+ Misses        629      627       -2     
+ Partials      490      488       -2     
Impacted Files Coverage Δ
pkg/v1/layout/options.go 100.00% <100.00%> (ø)
pkg/v1/layout/write.go 51.58% <100.00%> (+3.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf9d7b3...24c04e1. Read the comment docs.

Copy link
Collaborator

@deitch deitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this (but you knew that). Looking forward to expanding this once it is in.

Base automatically changed from master to main January 27, 2021 18:57
@jonjohnsonjr jonjohnsonjr merged commit 14945a4 into google:main Mar 2, 2021
@jonjohnsonjr jonjohnsonjr deleted the layout-options branch March 2, 2021 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants