crane auth get: convert back to credentials #898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, this would just print the AuthConfig that we get back from the config file read. This is often what we want, but it prevents crane from acting as a credential helper itself. By converting back to the credential helper structs, we can use crane as a meta-credential-helper that can multiplex over anything in your config file.
Codecov Report
@@ Coverage Diff @@
## master #898 +/- ##
=======================================
Coverage 72.53% 72.53%
=======================================
Files 108 108
Lines 4672 4672
=======================================
Hits 3389 3389
Misses 773 773
Partials 510 510 Continue to review full report at Codecov.
|
imjasonh
approved these changes
Jan 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, this would just print the AuthConfig that we get back from the
config file read. This is often what we want, but it prevents crane from
acting as a credential helper itself.
By converting back to the credential helper structs, we can use crane as
a meta-credential-helper that can multiplex over anything in your config
file.