-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop k8s.io/apimachinery/pkg/util/sets #903
Conversation
pkg/crane/optimize.go
Outdated
) | ||
|
||
// Optimize optimizes a remote image or index from src to dst. | ||
// THIS API IS EXPERIMENTAL AND SUBJECT TO CHANGE WITHOUT WARNING. | ||
func Optimize(src, dst string, prioritize sets.String, opt ...Option) error { | ||
func Optimize(src, dst string, prioritize []string, opt ...Option) error { | ||
pset := sets.NewString(prioritize...) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you are removing it from the public interface, then why not make it a private type alias of map[string]struct{}
and expose just what we need in set[_test].go
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, roughly.
Codecov Report
@@ Coverage Diff @@
## master #903 +/- ##
==========================================
+ Coverage 72.54% 72.60% +0.06%
==========================================
Files 108 108
Lines 4673 4687 +14
==========================================
+ Hits 3390 3403 +13
- Misses 773 774 +1
Partials 510 510
Continue to review full report at Codecov.
|
9b39d34
to
648d512
Compare
648d512
to
9f70474
Compare
Progress towards #902 (comment)