Drop k8s.io/apimachinery/pkg/util/sets #903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattmoor
reviewed
Jan 7, 2021
pkg/crane/optimize.go
Outdated
| ) | ||
|
|
||
| // Optimize optimizes a remote image or index from src to dst. | ||
| // THIS API IS EXPERIMENTAL AND SUBJECT TO CHANGE WITHOUT WARNING. | ||
| func Optimize(src, dst string, prioritize sets.String, opt ...Option) error { | ||
| func Optimize(src, dst string, prioritize []string, opt ...Option) error { | ||
| pset := sets.NewString(prioritize...) |
There was a problem hiding this comment.
if you are removing it from the public interface, then why not make it a private type alias of map[string]struct{} and expose just what we need in set[_test].go?
There was a problem hiding this comment.
Done, roughly.
Codecov Report
@@ Coverage Diff @@
## master #903 +/- ##
==========================================
+ Coverage 72.54% 72.60% +0.06%
==========================================
Files 108 108
Lines 4673 4687 +14
==========================================
+ Hits 3390 3403 +13
- Misses 773 774 +1
Partials 510 510
Continue to review full report at Codecov.
|
jonjohnsonjr
force-pushed
the
apimachinery
branch
from
9b39d34
to
648d512
Compare
jonjohnsonjr
changed the title
jonjohnsonjr
force-pushed
the
apimachinery
branch
from
648d512
to
9f70474
Compare
mattmoor
approved these changes
Jan 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress towards #902 (comment)