Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Access v1.Layer via our index impls #935

Merged
merged 3 commits into from
Feb 6, 2021
Merged

Access v1.Layer via our index impls #935

merged 3 commits into from
Feb 6, 2021

Conversation

jonjohnsonjr
Copy link
Collaborator

See #819

@jonjohnsonjr jonjohnsonjr marked this pull request as ready for review February 6, 2021 00:05
@jonjohnsonjr
Copy link
Collaborator Author

PTAL, added bunches of tests.

@dlorenc
Copy link
Contributor

dlorenc commented Feb 6, 2021

image
You love to see it

@jonjohnsonjr
Copy link
Collaborator Author

You love to see it

Someone has to care.

@clrprod I got your registry code back up to 100% coverage after @imjasonh desecrated it. Still need to drop the external dependencies back down to zero... babysteps.

@jonjohnsonjr jonjohnsonjr merged commit 4d068fb into google:main Feb 6, 2021
@jonjohnsonjr jonjohnsonjr deleted the index-layers branch February 6, 2021 00:16
This was referenced Mar 8, 2021
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imjasonh imjasonh imjasonh approved these changes

@dlorenc dlorenc dlorenc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jonjohnsonjr @dlorenc @imjasonh