Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MustParseReference #962

Merged
merged 1 commit into from
Mar 12, 2021
Merged

Add MustParseReference #962

merged 1 commit into from
Mar 12, 2021

Conversation

dekkagaijin
Copy link
Contributor

Makes testing and initializing other constish References less annoying

@jonjohnsonjr
Copy link
Collaborator

Trying to approve to unblock the actions?

@jonjohnsonjr
Copy link
Collaborator

I don't know what's going on.

@dekkagaijin
Copy link
Contributor Author

@jonjohnsonjr it ended up re-using the pre-existing executors that have been queued for the past 15+ hours

@jonjohnsonjr
Copy link
Collaborator

If you want to try to help, we can do this google/go-github#1821

@codecov-io
Copy link

Codecov Report

Merging #962 (ca5e6d3) into main (71a6fe9) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #962      +/-   ##
==========================================
- Coverage   73.12%   73.08%   -0.05%     
==========================================
  Files         107      107              
  Lines        4781     4796      +15     
==========================================
+ Hits         3496     3505       +9     
- Misses        768      775       +7     
+ Partials      517      516       -1     
Impacted Files Coverage Δ
pkg/name/ref.go 100.00% <100.00%> (ø)
pkg/v1/remote/write.go 64.30% <0.00%> (-0.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71a6fe9...ca5e6d3. Read the comment docs.

@dekkagaijin dekkagaijin merged commit d5f9e2c into google:main Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants