Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MustParseReference only accepts consts #964

Merged
merged 1 commit into from
Mar 13, 2021
Merged

Conversation

imjasonh
Copy link
Collaborator

Fixes #963

@codecov-io
Copy link

codecov-io commented Mar 12, 2021

Codecov Report

Merging #964 (ab83f83) into main (d5f9e2c) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #964      +/-   ##
==========================================
+ Coverage   73.08%   73.13%   +0.05%     
==========================================
  Files         107      107              
  Lines        4796     4828      +32     
==========================================
+ Hits         3505     3531      +26     
- Misses        775      780       +5     
- Partials      516      517       +1     
Impacted Files Coverage Δ
pkg/name/ref.go 100.00% <100.00%> (ø)
pkg/registry/manifest.go 93.29% <0.00%> (-2.68%) ⬇️
pkg/registry/registry.go 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5f9e2c...90ea90b. Read the comment docs.

Copy link
Collaborator

@jonjohnsonjr jonjohnsonjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@dekkagaijin dekkagaijin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, very sneaky sir

pkg/name/ref.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make MustParseReference only accept consts
4 participants