Use name.MustParseReference in some tests #965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonjohnsonjr
approved these changes
Mar 19, 2021
Codecov Report
@@ Coverage Diff @@
## main #965 +/- ##
=======================================
Coverage 75.19% 75.19%
=======================================
Files 107 107
Lines 4837 4837
=======================================
Hits 3637 3637
Misses 669 669
Partials 531 531 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to these usages,
pkg/v1/remotetests also havemustNewTag, which regularly takes a var string to be able to be derived from a dynamically-generated in-memory host.