Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use errgroup consistently in MultiWrite #966

Merged
merged 1 commit into from
Mar 15, 2021
Merged

Conversation

imjasonh
Copy link
Collaborator

#958 added support for WithJobs to remote.Write, etc., and added context timeout/cancellation handling (correctly, we think) at the same time.

This change ports that context handling to remote.MultiWrite (correctly, we think). If it's not correct, it's at least consistently incorrect.

@codecov-io
Copy link

Codecov Report

Merging #966 (20608e4) into main (bea57ad) will decrease coverage by 0.01%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #966      +/-   ##
==========================================
- Coverage   73.13%   73.11%   -0.02%     
==========================================
  Files         107      107              
  Lines        4828     4832       +4     
==========================================
+ Hits         3531     3533       +2     
- Misses        780      782       +2     
  Partials      517      517              
Impacted Files Coverage Δ
pkg/v1/remote/multi_write.go 57.01% <75.00%> (-0.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bea57ad...20608e4. Read the comment docs.

@imjasonh imjasonh merged commit 29b86b5 into google:main Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants