-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crane digest: fallback to GET when HEAD fails #971
Conversation
Codecov Report
@@ Coverage Diff @@
## main #971 +/- ##
==========================================
+ Coverage 75.19% 75.23% +0.04%
==========================================
Files 107 107
Lines 4837 4850 +13
==========================================
+ Hits 3637 3649 +12
- Misses 669 670 +1
Partials 531 531
Continue to review full report at Codecov.
|
LGTM in general. One thing I'm slightly worried about is the headManifest errors not making sense out of context. WDYT about prepending them with |
b504b62
to
5e8022c
Compare
Good call, done. Added tests. |
5e8022c
to
def730a
Compare
One final nit is that the reason this error was particularly confusing is here: go-containerregistry/pkg/v1/hash.go Line 90 in 4a92f6c
In particular, "too many" is definitely wrong for Can we make that slightly better? |
Updated to |
b19fb28
to
8f3a1d0
Compare
Before
My, what a very unhelpful error message that is! 🤔
After
This should also make
crane digest
work against registries that don't supportHEAD
at all, or that don't include all the necessary descriptor information in response headers, though neglectingDocker-Content-Digest
is probably by far the most common omission.If this lgty in general I can add some tests.