-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow multiple images pull #975
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
1 similar comment
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
Thanks for the PR!
Definitely interesting and something I'd like to support. CLI UX looks good to me, but I'm a little reluctant to modify the signature for Do you mind instead adding three new functions?
Then we can rewrite |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM beyond a couple small nits.
Can you also add godoc comments to the Multi funcs?
Codecov Report
@@ Coverage Diff @@
## main #975 +/- ##
==========================================
- Coverage 74.75% 74.59% -0.17%
==========================================
Files 107 107
Lines 5007 5022 +15
==========================================
+ Hits 3743 3746 +3
- Misses 710 721 +11
- Partials 554 555 +1
Continue to review full report at Codecov.
|
Hi jonjohnsonjr, Please find update adding comment on MultiWrite method and rework on MultiWriteOCI. Best Regards, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Hi,
Please find this PR that intend to pull multiple images and save it to a tar file that could be loaded by docker load.
It is a quick & dirty try, let me know if you think this feature extension is interesting or if there is an other way to do this with the cli.
Best Regards,
Michel.