Add remote.Put() to upload a manifest via digest #980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonjohnsonjr
requested changes
Apr 12, 2021
pkg/v1/remote/write.go
Outdated
| // Digest does not attempt to write anything other than the manifest, so callers | ||
| // should ensure that all blobs or manifests that are referenced by t exist | ||
| // in the target registry. | ||
| func Digest(digest name.Digest, t Taggable, options ...Option) error { |
There was a problem hiding this comment.
I'd lean towards just remote.Put for this, I think. The existing remote.Tag is using "tag" as a verb here, not as a noun, so calling this Digest doesn't make a ton of sense.
remote.Put would also mirror remote.Get, remote.Head, and remote.Delete.
It should take a name.Reference as well, IMO (basically just exposing manifestReference as Put).
deitch
force-pushed
the
push-manifest-digest
branch
from
873b9a1
to
a738acf
Compare
jonjohnsonjr
approved these changes
Apr 14, 2021
|
LGTM, a test would be cool, but just rebasing also works :) |
Signed-off-by: Avi Deitcher <avi@deitcher.net>
deitch
force-pushed
the
push-manifest-digest
branch
from
a738acf
to
4daeac7
Compare
|
Rebased. |
|
Thanks! |
jonjohnsonjr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @jonjohnsonjr . We already have remote.Tag which uploads a manifest and references it with a tag. However, there also is the ability in the API to upload a manifest and just reference it via its digest, just like any other blob. Eventually, the manifest should be referenced by another manifest or a tag, but those are independent.