Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for symbol link inside docker tar file #987

Merged
merged 3 commits into from
Apr 21, 2021

Conversation

yongxiu
Copy link
Contributor

@yongxiu yongxiu commented Apr 20, 2021

docker tar file containing multiple images will have symbol link for layer files to save space, this will read from the target file instead of the symbol link file

* docker tar file containing multiple images will have symbol link for
layer files to save space, this will read from the target file instead
of the symbol link file
@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2021

Codecov Report

Merging #987 (7a14a3f) into main (7b64627) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 7a14a3f differs from pull request most recent head 4d5a3fd. Consider uploading reports for the commit 4d5a3fd to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #987      +/-   ##
==========================================
+ Coverage   74.60%   74.61%   +0.01%     
==========================================
  Files         107      107              
  Lines        5040     5043       +3     
==========================================
+ Hits         3760     3763       +3     
  Misses        725      725              
  Partials      555      555              
Impacted Files Coverage Δ
pkg/v1/tarball/image.go 78.20% <100.00%> (+0.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b64627...4d5a3fd. Read the comment docs.

Copy link
Collaborator

@jonjohnsonjr jonjohnsonjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall lgtm other than that one question. Can you add a test as well?

There are some test tarball archives under https://github.com/google/go-containerregistry/tree/main/pkg/v1/tarball/testdata

pkg/v1/tarball/image.go Show resolved Hide resolved
@yongxiu
Copy link
Contributor Author

yongxiu commented Apr 21, 2021

Overall lgtm other than that one question. Can you add a test as well?

There are some test tarball archives under https://github.com/google/go-containerregistry/tree/main/pkg/v1/tarball/testdata

Added, please take another look, thanks.

@jonjohnsonjr
Copy link
Collaborator

Thanks!

@jonjohnsonjr jonjohnsonjr merged commit daa5add into google:main Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants