Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor pkg/v1/daemon #989

Merged
merged 1 commit into from
Apr 21, 2021
Merged

Conversation

jonjohnsonjr
Copy link
Collaborator

Fixes #857

Use options for everything, including injecting clients for testing.

Add WithContext option.

Un-thunkify some of daemon.Image to make it a bit clearer.

Add more test coverage: actually caught one bug where we were returning
the wrong error if we failed to read from the daemon response body.

Use options for everything, including injecting clients for testing.

Add WithContext option.

Un-thunkify some of daemon.Image to make it a bit clearer.

Add more test coverage: actually caught one bug where we were returning
the wrong error if we failed to read from the daemon response body.
@codecov-commenter
Copy link

Codecov Report

Merging #989 (34320a2) into main (23990da) will increase coverage by 0.45%.
The diff coverage is 90.14%.

❗ Current head 34320a2 differs from pull request most recent head 4a78b0c. Consider uploading reports for the commit 4a78b0c to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #989      +/-   ##
==========================================
+ Coverage   74.61%   75.07%   +0.45%     
==========================================
  Files         107      107              
  Lines        5027     5027              
==========================================
+ Hits         3751     3774      +23     
+ Misses        721      708      -13     
+ Partials      555      545      -10     
Impacted Files Coverage Δ
pkg/v1/google/list.go 62.92% <ø> (ø)
pkg/v1/google/options.go 90.00% <ø> (ø)
pkg/gcrane/options.go 77.77% <66.66%> (-22.23%) ⬇️
pkg/v1/daemon/options.go 90.47% <90.47%> (-9.53%) ⬇️
pkg/gcrane/copy.go 84.49% <90.90%> (+0.12%) ⬆️
pkg/v1/daemon/image.go 100.00% <100.00%> (+37.50%) ⬆️
pkg/v1/daemon/write.go 100.00% <100.00%> (+53.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d8559c...4a78b0c. Read the comment docs.

@jonjohnsonjr jonjohnsonjr merged commit 2bd4a53 into google:main Apr 21, 2021
@jonjohnsonjr jonjohnsonjr deleted the daemon-refactor branch April 21, 2021 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

daemon.{Write,Tag} should take WithClient option
3 participants