Tag crane/gcrane images with Git tag #990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imjasonh
force-pushed
the
cloudbuild-tag
branch
2 times, most recently
from
a5cbec9
to
b24da46
Compare
imjasonh
force-pushed
the
cloudbuild-tag
branch
from
b24da46
to
dfae274
Compare
Codecov Report
@@ Coverage Diff @@
## main #990 +/- ##
==========================================
- Coverage 75.21% 75.18% -0.03%
==========================================
Files 107 107
Lines 5063 5061 -2
==========================================
- Hits 3808 3805 -3
- Misses 710 711 +1
Partials 545 545
Continue to review full report at Codecov.
|
imjasonh
force-pushed
the
cloudbuild-tag
branch
from
dfae274
to
168b005
Compare
imjasonh
force-pushed
the
cloudbuild-tag
branch
from
168b005
to
08a656c
Compare
imjasonh
force-pushed
the
cloudbuild-tag
branch
from
08a656c
to
9520b1b
Compare
jonjohnsonjr
approved these changes
Apr 23, 2021
|
Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #755
When the tag name is set, this will produce images like:
gcr.io/go-containerregistry/crane:vX.Y.Zgcr.io/go-containerregistry/crane:debug-vX.Y.ZWhen the tag name is not set (building an untagged commit), it will produce images as normal (e.g.,
gcr.io/go-containerregistry/crane:abcdefand:latest).Also update the
koversion used to build images, and fail if using an unset env var.