Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add presubmit workflow #994

Merged
merged 1 commit into from
Apr 23, 2021
Merged

Add presubmit workflow #994

merged 1 commit into from
Apr 23, 2021

Conversation

jonjohnsonjr
Copy link
Collaborator

Fix all the things that it caught :(

Fix all the things that it caught :(
@codecov-commenter
Copy link

Codecov Report

Merging #994 (1db72c4) into main (37467b5) will increase coverage by 0.01%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #994      +/-   ##
==========================================
+ Coverage   75.18%   75.19%   +0.01%     
==========================================
  Files         107      107              
  Lines        5061     5064       +3     
==========================================
+ Hits         3805     3808       +3     
  Misses        711      711              
  Partials      545      545              
Impacted Files Coverage Δ
pkg/v1/layout/write.go 49.16% <0.00%> (ø)
pkg/registry/manifest.go 93.33% <100.00%> (+0.03%) ⬆️
pkg/registry/registry.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37467b5...1db72c4. Read the comment docs.

branches: [ 'main', 'master' ]

pull_request:
branches: [ 'main', 'master', 'release-*' ]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't actually need master and release-* right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we need to patch release branches, we'll want that (I think).

All our other workflows work against master, and this has been useful for me. I keep my fork's default branch as master to easily (and lazily) differentiate it from this repo's main branch, so I don't accidentally push the wrong thing ever.

@jonjohnsonjr jonjohnsonjr merged commit 83f4080 into google:main Apr 23, 2021
@jonjohnsonjr jonjohnsonjr deleted the presubmit branch April 23, 2021 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants