Plumb context through crane and gcrane #995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #995 +/- ##
==========================================
- Coverage 75.24% 75.15% -0.09%
==========================================
Files 107 107
Lines 5058 5064 +6
==========================================
Hits 3806 3806
- Misses 706 712 +6
Partials 546 546
Continue to review full report at Codecov.
|
imjasonh
reviewed
Apr 23, 2021
| @@ -29,5 +29,5 @@ func Catalog(src string, opt ...Option) (res []string, err error) { | |||
| return nil, err | |||
| } | |||
|
|
|||
| return remote.Catalog(context.TODO(), reg, o.remote...) | |||
| return remote.Catalog(context.Background(), reg, o.remote...) | |||
There was a problem hiding this comment.
Not plumbing context through here?
There was a problem hiding this comment.
The remote.WithContext in o.remote... will override it.
| @@ -61,8 +62,9 @@ func main() { | |||
| root.AddCommand(cmd) | |||
| } | |||
|
|
|||
| if err := root.Execute(); err != nil { | |||
| fmt.Println(err) | |||
| ctx, cancel := signal.NotifyContext(context.Background(), os.Interrupt) | |||
There was a problem hiding this comment.
defer cancel () instead?
There was a problem hiding this comment.
Doesn't os.Exit(1) pre-empt it?
There was a problem hiding this comment.
ended up doing both instead
imjasonh
approved these changes
May 14, 2021
jonjohnsonjr
force-pushed
the
contexts
branch
2 times, most recently
from
053a029
to
3750ef0
Compare
imjasonh
approved these changes
May 18, 2021
Also, use signal.NotifyContext for cancelling the ctx.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #912
Also, use signal.NotifyContext for cancelling the ctx.
Also, don't log errors twice now that we're using RunE.