Fix JSON unmarshal error of App.app.events #1370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I got following error. json: cannot unmarshal string into Go struct field App.app.events of type github.Event It's regression from google#1283 and event type should be actually string [1][2]. [1]: https://developer.github.com/v3/apps/#get-a-single-github-app [2]: https://developer.github.com/v3/repos/branches/#list-apps-with-access-to-protected-branch
googlebot
added
the
cla: yes
gmlewis
approved these changes
Jan 10, 2020
|
@gmlewis Can you release new patch version (v29.0.2)? v29 is broken unless including this fix. |
|
Yes indeed. Releasing 29.0.2 now. |
|
Thanks! 👍 |
n1lesh
pushed a commit
to n1lesh/go-github
that referenced
this pull request
Oct 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got following error.
json: cannot unmarshal string into Go struct field App.app.events of
type github.Event
It's regression from #1283 and event type should be actually string.
https://developer.github.com/v3/apps/#get-a-single-github-app
https://developer.github.com/v3/repos/branches/#list-apps-with-access-to-protected-branch